hi stuart, thanks for your response.

On 01/17/17 23:10, Stuart Henderson wrote:
Hi, some quick feedback :

Makefile:
- "ONLY_FOR_ARCHS =  amd64 i386", why?

this was due to a build i tried on armv7 which failed with:

    Error: selected processor does not support `fmrx r3,fpscr'

i figured this was inline x86 assembly but your question promted
metolook further. turns out its an issue with floating point
instructionson arm.

i tried copying other ports with `--target=generic' and
`--arch=generic' in CONFIGURE_ARGS with no success. then i tried
CFLAGS+='-mfloat-abi=hard' which the base gcc must not support?
pulling in ports' gcc got me a bit further:

    {standard input}: Assembler messages:
{standard input}:18: Error: selected processor does not support `fstmfdd sp!,{d8,d9}'
    {standard input}:19: Error: unknown pseudo-op: `.vsave'
{standard input}:24: Error: selected processor does not support `fcpyd d9,d0' {standard input}:25: Error: selected processor does not support `fcpyd d8,d1' {standard input}:37: Error: selected processor does not support `fcpyd d0,d9' {standard input}:38: Error: selected processor does not support `fcpyd d1,d8' {standard input}:46: Error: selected processor does not support `fldmfdd ip!,{d8-d9}'

unsure how to proceed, uncertain what OpenBSD support
for hardware floating point is like on armv7.

- "#GPLv2 only" please add a space, "# GPLv2 only"
- "COMMENT = Library for ..." lower-case first letter -> "library for"

pkg/DESCR:
- don't list WWW, it comes automatically from HOMEPAGE in Makefile

pkg/PLIST, Makefile:
- the linux-style shared library handling needs modifying.

the attached tarball should have fixed these issues.


Since you are pretty new to ports on OpenBSD, please get the first
one in good shape before sending others, as most of my comments apply
to the others too.


sure thing, sorry for the noise, i now realise it was
poor etiquette.

thanks for having a look at this,
toby/

Attachment: rubberband.tar.gz
Description: application/gzip

Reply via email to