On Thu, Jul 20, 2017 at 11:32:04AM +0200, Matthias Pitzl wrote: > Good point. I checked the port for Data::Alias and I don't think there's an > easy > fix for this module. There are several bug tickets on CPAN about problems with > newer Perl versions.
Should we mark the p5-Data-Alias port broken in OpenBSD? > But, Data::Alias is only an optional dependency for Data::Visitor. > I updated my diff with your additions and removed the dependency to > Data::Alias. > With this, the tests of Data::Visitor are ok again. But I have to pkg_delete p5-Data-Alias to make p5-Data-Visitor work. So Data::Visitor would fail depending on the installed package set. That is bad. Either we consider p5-Data-Alias broken beyond repair and remove the port, or you patch p5-Data-Visitor that it never uses Data::Alias, or both. bluhm > Index: devel/p5-Data-Visitor/Makefile > =================================================================== > RCS file: /openbsd/ports/devel/p5-Data-Visitor/Makefile,v > retrieving revision 1.21 > diff -u -p -r1.21 Makefile > --- devel/p5-Data-Visitor/Makefile 20 Mar 2016 19:56:18 -0000 1.21 > +++ devel/p5-Data-Visitor/Makefile 20 Jul 2017 08:20:44 -0000 > @@ -4,20 +4,19 @@ COMMENT= visitor-style traversal of Perl > > MODULES= cpan > PKG_ARCH= * > -DISTNAME= Data-Visitor-0.27 > +DISTNAME= Data-Visitor-0.30 > CATEGORIES= devel > -REVISION= 0 > > # perl > PERMIT_PACKAGE_CDROM= Yes > > -RUN_DEPENDS= devel/p5-Data-Alias \ > +RUN_DEPENDS= devel/p5-Class-Load>=0.06 \ > devel/p5-Moose>=0.89 \ > devel/p5-Task-Weaken \ > - devel/p5-Tie-ToObject \ > - devel/p5-namespace-clean > + devel/p5-Tie-ToObject>=0.01 \ > + devel/p5-namespace-clean>=0.19 > > -TEST_DEPENDS=devel/p5-Test-MockObject>=1.04 \ > - devel/p5-Test-use-ok > +TEST_DEPENDS= devel/p5-Test-Requires \ > + devel/p5-Test-Script>=1.05 > > .include <bsd.port.mk> > Index: devel/p5-Data-Visitor/distinfo > =================================================================== > RCS file: /openbsd/ports/devel/p5-Data-Visitor/distinfo,v > retrieving revision 1.12 > diff -u -p -r1.12 distinfo > --- devel/p5-Data-Visitor/distinfo 18 Jan 2015 03:13:24 -0000 1.12 > +++ devel/p5-Data-Visitor/distinfo 20 Jul 2017 08:20:44 -0000 > @@ -1,2 +1,2 @@ > -SHA256 (Data-Visitor-0.27.tar.gz) = > UiGKIvpDuzUV7VMJjVl+6g3xKdY3/aifXYjcf49gs50= > -SIZE (Data-Visitor-0.27.tar.gz) = 15051 > +SHA256 (Data-Visitor-0.30.tar.gz) = > jqJKvMNlnnYKqUruK6fdVMrK8gMCcFUkFD85VUAJ7VQ= > +SIZE (Data-Visitor-0.30.tar.gz) = 24542
