On 20.07.2017 - 13:08:13, Alexander Bluhm wrote:
> On Thu, Jul 20, 2017 at 12:39:46PM +0200, Matthias Pitzl wrote:
> > The attached diff adds a patch for Data::Visitor preventing the loading of
> > Data::Alias.
>
> Test pass, but make regress gives this ugly output:
>
> t/magic.t ................ ok
> perl:/usr/local/libdata/perl5/site_perl/amd64-openbsd/auto/Data/Alias/Alias.so:
> undefined symbol 'POPFORMAT'
> perl:/usr/local/libdata/perl5/site_perl/amd64-openbsd/auto/Data/Alias/Alias.so:
> undefined symbol 'POPEVAL'
> perl:/usr/local/libdata/perl5/site_perl/amd64-openbsd/auto/Data/Alias/Alias.so:
> undefined symbol 'POPBLOCK'
> perl:/usr/local/libdata/perl5/site_perl/amd64-openbsd/auto/Data/Alias/Alias.so:
> undefined symbol 'LEAVESUB'
> perl:/usr/local/libdata/perl5/site_perl/amd64-openbsd/auto/Data/Alias/Alias.so:
> undefined symbol 'POPSUB'
> t/weak.t ................. skipped: Can't load
> '/usr/local/libdata/perl5/site_perl/amd64-openbsd/auto/Data/Alias/Alias.so'
> for module Data::Alias: Cannot load specified object at
> /usr/libdata/perl5/amd64-openbsd/DynaLoader.pm line 193.
> All tests successful.
> Files=11, Tests=107, 3 wallclock secs ( 0.02 usr 0.05 sys + 2.65 cusr
> 0.42 csys = 3.14 CPU)
> Result: PASS
>
> I think you also should patch the final Perl test.
>
> bluhm
Hi Alex,
Now the tests run without ugly output. Added a diff for the weak.t patch to
skip it completely.
-- Matthias
Index: Makefile
===================================================================
RCS file: /openbsd/ports/devel/p5-Data-Visitor/Makefile,v
retrieving revision 1.21
diff -u -p -r1.21 Makefile
--- Makefile 20 Mar 2016 19:56:18 -0000 1.21
+++ Makefile 20 Jul 2017 11:38:12 -0000
@@ -4,20 +4,19 @@ COMMENT= visitor-style traversal of Perl
MODULES= cpan
PKG_ARCH= *
-DISTNAME= Data-Visitor-0.27
+DISTNAME= Data-Visitor-0.30
CATEGORIES= devel
-REVISION= 0
# perl
PERMIT_PACKAGE_CDROM= Yes
-RUN_DEPENDS= devel/p5-Data-Alias \
+RUN_DEPENDS= devel/p5-Class-Load>=0.06 \
devel/p5-Moose>=0.89 \
devel/p5-Task-Weaken \
- devel/p5-Tie-ToObject \
- devel/p5-namespace-clean
+ devel/p5-Tie-ToObject>=0.01 \
+ devel/p5-namespace-clean>=0.19
-TEST_DEPENDS=devel/p5-Test-MockObject>=1.04 \
- devel/p5-Test-use-ok
+TEST_DEPENDS= devel/p5-Test-Requires \
+ devel/p5-Test-Script>=1.05
.include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /openbsd/ports/devel/p5-Data-Visitor/distinfo,v
retrieving revision 1.12
diff -u -p -r1.12 distinfo
--- distinfo 18 Jan 2015 03:13:24 -0000 1.12
+++ distinfo 20 Jul 2017 11:38:12 -0000
@@ -1,2 +1,2 @@
-SHA256 (Data-Visitor-0.27.tar.gz) =
UiGKIvpDuzUV7VMJjVl+6g3xKdY3/aifXYjcf49gs50=
-SIZE (Data-Visitor-0.27.tar.gz) = 15051
+SHA256 (Data-Visitor-0.30.tar.gz) =
jqJKvMNlnnYKqUruK6fdVMrK8gMCcFUkFD85VUAJ7VQ=
+SIZE (Data-Visitor-0.30.tar.gz) = 24542
--- /dev/null Thu Jul 20 14:18:44 2017
+++ patches/patch-lib_Data_Visitor_pm Thu Jul 20 12:12:42 2017
@@ -0,0 +1,14 @@
+$OpenBSD$
+
+Index: lib/Data/Visitor.pm
+--- lib/Data/Visitor.pm.orig
++++ lib/Data/Visitor.pm
+@@ -22,7 +22,7 @@ use namespace::clean -except => 'meta';
+ # the double not makes this no longer undef, so exempt from useless constant
warnings in older perls
+ use constant DEBUG => not not our $DEBUG || $ENV{DATA_VISITOR_DEBUG};
+
+-use constant HAS_DATA_ALIAS => load_optional_class('Data::Alias');
++use constant HAS_DATA_ALIAS => 0;
+
+ has tied_as_objects => (
+ isa => "Bool",
--- /dev/null Thu Jul 20 14:18:54 2017
+++ patches/patch-t_weak_t Thu Jul 20 14:17:54 2017
@@ -0,0 +1,14 @@
+$OpenBSD$
+
+Index: t/weak.t
+--- t/weak.t.orig
++++ t/weak.t
+@@ -3,7 +3,7 @@
+ use strict;
+ use warnings;
+
+-use Test::More;
++use Test::More skip_all => 'Data::Alias is broken';
+
+ use Test::Requires 'Data::Alias';
+
