On Mon, Jul 24, 2017 at 02:15:57PM -0500, attila wrote: > > Landry Breuil <[email protected]> writes: > > > On Sat, Jul 22, 2017 at 09:56:00AM -0500, attila wrote: > >> > >> attila <[email protected]> writes: > >> > >> > Hi ports@, > >> > > >> > Attached is an update from Tor Browser 6.5.2 to the latest release, > >> > 7.0.2. I would really appreciate some testing if anyone has the time. > >> > >> An alert reader pointed out in private email that my patch was missing > >> a new file due to a forgotten cvs add. Revised patch attached with > >> the missing file. > > > > Can you elaborate a bit more on the files/configure file ? it isnt > > provided by the tbb devs in the released tarball ? > > No, there's no configure script in the tree that I grab from their git > repo and push onto GH for tarball purposes. There is a configure.in, > which looks like a temporary placeholder to keep old autoconf-based > stuff happy. Unfortunately, running their configure.in through m4 > produced a sh script with a syntax error. I didn't think this was > worth a patch upstream because it looks like configure.in is going to > go away eventually. > > I have attached an alternate update here that dispenses with > files/configure (which is the script that m4 configure.in *should* > have produced) and instead patches configure.in and > js/src/configure.in to not produce a sh script with unbalanced quotes > when run through m4. This is a short-term fix to get > CONFIGURE_STYLE=simple to work here like it does for firefox-esr; I > found doing anything but CONFIGURE_STYLE=simple pulls in a bunch of > gnu stuff that breaks me later (I forget the details).
myeah, i dont really have an opinion on that mess, but the autoconf goo is going away someday. I see that all sub-ports were also bumped so we shouldnt have update issues. No opinion on the update itself, it looks fine portswise (i'm just not sure at all the gettext module is needed anymore) - someone running this should take care of properly testing it. I think you can remove the skia/gfx patches for i386, iirc they're not needed in 52. To be tested. Landry
