On 2017/07/24 22:33, Landry Breuil wrote:
> myeah, i dont really have an opinion on that mess, but the autoconf goo
> is going away someday. I see that all sub-ports were also bumped so we
> shouldnt have update issues. No opinion on the update itself, it looks
> fine portswise (i'm just not sure at all the gettext module is needed
> anymore)
Yep we're trying to get rid of gettext module use, I'd rather not re-add it
as this diff does.
> - someone running this should take care of properly testing it.
Presumably Sean has already done that so we are probably just down to
ports nitpicking now :)
: -# there are sometimes .orig files in the source, messes with update-patches
: post-extract:
: + # there have been .orig files in source, messes with update-patches
: -find ${WRKSRC} -name '*.orig' -exec rm {} \;
Probably better to set PATCHORIG, this will avoid the need for running this
find(1) across the source tree for each build.
: # relies on pulseaudio for sound and broken at runtime
: -CONFIGURE_ARGS += --disable-webrtc
: -
: -CONFIGURE_ARGS += --disable-gstreamer
: +#CONFIGURE_ARGS += --disable-webrtc
It looks a bit odd to have a commented-out --disable-webrtc here, was
that intentional?
> I think you can remove the skia/gfx patches for i386, iirc they're not
> needed in 52. To be tested.
Since they're no longer present in firefox-esr I would be ok with just
dropping them, if I run into problems in i386 bulk I can always re-add them.
