Hi Edd,

Thanks for the review.

> ---8<---
> $ make port-lib-depends-check
> k2pdfopt-2.42(converters/k2pdfopt):
> Missing: djvulibre.26 from djvulibre-3.5.27p2 (/usr/local/bin/k2pdfopt)
> Missing: jasper.2 from jasper-1.900.1p5 (/usr/local/bin/k2pdfopt)
> Missing: lept.2 from leptonica-1.74 (/usr/local/bin/k2pdfopt)
> Missing: mupdf.6 from mupdf-1.11p0 (/usr/local/bin/k2pdfopt)
> Missing: openjpeg.5 from openjpeg-1.5.2 (/usr/local/bin/k2pdfopt)
> Missing: tesseract.3 from tesseract-3.05.00p0 (/usr/local/bin/k2pdfopt)
> WANTLIB += djvulibre jasper lept mupdf openjpeg tesseract
> --->8---

I added those to WANTLIB.

> Shame about the need to have the dependency sources available. According
> to `port-lib-depends-check` the shared objects are used too.

Yes, the port uses the libraries and the source files are needed because
the author also adds extra functionality for them.

> If you try converting this paper:
> https://arxiv.org/pdf/1602.00602
> 
> It will crash converting page 32.

I have one such paper too. But the code is horrible: 0 comments and
random variable names.

> I tried to get a trace, but the usual `DEBUG=-g` trick seems to cause a
> linker error.

It's because of the stupid context.h header from mupdf

  #if defined(MEMENTO) || !defined(NDEBUG)
  #define FITZ_DEBUG_LOCKING
  #endif

Why they have this in the header is beyond me! Just add #undef after
that block if you want working debugging...

> Other than the, the ports looks alright. I tried reading a paper on my
> Kindle. It's kinda readable, but I guess you can't expect perfection.

Are you sure you defined the proper screen size? It looks perfect on my
Kindle Oasis!

So is that an OK? :)

Paul

Attachment: k2pdfopt.tgz
Description: application/tar-gz

Reply via email to