On Mon, November 13, 2017 19:49, Brian Callahan wrote:
> Now looking for oks.
>
> On 11/13/17 11:05, Brian Callahan wrote:
>>
>> On 11/13/17 10:36, Kirill Bychkov wrote:
>>> On Sun, November 12, 2017 22:27, Brian Callahan wrote:
>>>> On 11/12/17 14:08, Kirill Bychkov wrote:
>>>>> On Sun, November 12, 2017 20:12, Edd Barrett wrote:
>>>>>> Hi,
>>>>>>
>>>>>> On Sun, Nov 12, 2017 at 11:49:20AM -0500, Brian Callahan wrote:
>>>>>>> devel/luabitop is a BDEP of editors/neovim. devel/lua-bitop is
>>>>>>> not used by
>>>>>>> anything (at least, as far as `make search key=lua-bitop` suggests).
>>>>>>> devel/luabitop also appears to be the more comprehensive port.
>>>>>>>
>>>>>>> OK to remove devel/lua-bitop?
>>>>>> Ugh. IIRC, I imported lua-bitop for neovim, probably missing luabitop
>>>>>> becuase it wasn't prefixed 'lua-'. Somehow I then managed to
>>>>>> depend on
>>>>>> the existing luabitop.
>>>>>>
>>>>>> I've checked using sqlports that there are no other dependents, so
>>>>>> your
>>>>>> plan seems sensible to me. OK edd@, but perhaps wait a bit and see if
>>>>>> anyone else chimes in.
>>>>>>
>>>>>> Thanks
>>>>>>
>>>>> Hi!
>>>>> lua- prefix is a standard. IMHO you should remove luabitop and add
>>>>> lua-bitop
>>>>> as a dependency to neovim.
>>>>> Just my 2 cents.
>>>>>
>>>> Or should luabitop be moved to lua-bitop?
>>>>
>>> I think you need to merge all the tweaks from both ports in lua-bitop
>>> and
>>> remove luabitop directory with all quirks and @pkgpath dance.
>>>
>>
>> Right. That's what I was thinking.
>>
>
> Merging diff attached. Missing from this diff is the bump and depends
> switch in editors/neovim, but that comes after.
>
> ~Brian
>
>
Some comments:
- you're missing REVISION bump after changing PLIST and COMMENT
- you need @conflict marker for luabitop because you're shipping docs now
- and you can switch to https while here.
