On Sat, Dec 23, 2017 at 01:20:05PM +0100, Landry Breuil wrote:
> On Mon, Dec 18, 2017 at 08:23:34PM +0100, Landry Breuil wrote:
> > On Thu, Dec 14, 2017 at 09:17:11PM +0100, Klemens Nanni wrote:
> > > On Wed, Dec 13, 2017 at 04:39:57PM +0100, Landry Breuil wrote:
> > > > Starting from this i dunno if it warrants a readme or a MESSAGE, you
> > > > just need to go fetch the access/secret keys in the config file after
> > > > first startup, and maybe bump maxfiles limits for minio (as advised on
> > > > https://github.com/minio/minio-service - the sysv init script bumps to
> > > > 8k)
> > > Users should know how to use minio, I'd say it's fine without
> > > further explanation.
> > >
> > > $ portcheck
> > > Makefile.inc does not have $OpenBSD$ RCS tag at the top
> > > hardcoded paths detected in server/pkg/minio.rc, consider \
> > > using SUBST_VARS and TRUEPREFIX/LOCALBASE/LOCALSTATEDIR/VARBASE
> > > net/minio
> > >
> > > s,/var,${VARBASE},
> >
> > With those fixed.
>
> Now with mc updated to 20171212
> (cf https://github.com/minio/mc/releases/tag/RELEASE.2017-12-12T01-08-02Z)
> and the single patch in an upstream PR
> at https://github.com/minio/mc/pull/2342
Looks good to me. I'd probably sync usage of blank lines in all
Makefiles but that's personal taste.
GH_PROJECT is set in both {client/server}/Makefile so this will do:
--- Makefile.inc.orig
+++ Makefile.inc
@@ -1,7 +1,6 @@
# $OpenBSD$
-GH_ACCOUNT ?= minio
-GH_PROJECT ?= minio
+GH_ACCOUNT = minio
CATEGORIES = net sysutils
