Hi,
On Sun, Feb 18, 2018 at 11:40:53AM +0100, Caspar Schutijser wrote:
> Attached is a new port: devel/hs-ShellCheck, a shell script analysis
> tool. It depends on textproc/hs-json for which I just sent a new port
> because it is not in the ports tree yet.
>
> This port provides both a utility (bin/shellcheck), and a Haskell
> library. Should I split up the port into -main and -lib subpackages,
> just like x11/xmonad? Another approach is to let the user use cabal
> to get the library, and not install the library at all.
I don't know how useful the library is, but it shouldn't hurt to
do it as a subpackage. Please call the port and the main package
just shellcheck, and the library package hs-shellcheck. devel/cpphs
may provide a better examples for this than x11/xmonad.
For the port itself: line length nitpicking on pkg/DESCR applies
the same aas for your devel/hs-hson port ;-)
The (build and run) dependencies devel/hs-mtl and devel/hs-QuickCheck
should be restricted to minimum required versions as in the .cabal file,
i.e.
devel/hs-mtl>=2.2.1
and
devel/hs-QuickCheck>=2.7.4
The comment above the NO_TEST should probably removed (from which
port did you copy that? ;-))
And if it has a working test suite that doesn't require additional
dependencies, just drop the NO_TEST at all.
Ciao,
Kili
