Thank you sthen@ for reviewing the port. Attached is the port with
suggested changes, problems that kn@ pointed out (thanks!) are
fixed as well.

Best

On Sun, May 6, 2018 at 1:08 PM, Stuart Henderson <s...@spacehopper.org>
wrote:

> On 2018/05/06 00:01, Ljuba Nedeljkovic wrote:
> > Attached is the port of nnn, version 1.8. Upstream is releasing
> > source tarball as a formal/proper release so GH_* are gone.
> > Patch (present in previous port submissions) is also gone since
> > upstream fixed portability issue with shell script.
> >
> > Tests/comments.suggestions are welcome.
>
> I'm no fan of this:
>
> #!/usr/bin/env bash
>
> It's not deterministic (relies on the user's PATH being set in a certain
> way), I would normally patch these to use ${LOCALBASE}/bin/bash like you
> had
> in earlier versions of your port.
>
>


-- 
If you wish to live wisely,
ignore sayings -- including this one.

Attachment: nnn-1.8.tar.gz
Description: application/gzip

Reply via email to