On Fri, May 11 2018, Stuart Henderson <[email protected]> wrote: > On 2018/05/11 13:54, Jeremie Courreges-Anglas wrote: >> On Wed, May 09 2018, Stuart Henderson <[email protected]> wrote: >> > On 2018/05/09 08:34, Jeremie Courreges-Anglas wrote: >> >> On Sun, May 06 2018, Kaashif Hymabaccus <[email protected]> wrote: >> >> > On Mon, Apr 30, 2018 at 05:51:31PM +0200, Solene Rapenne wrote: >> >> >> >> >> >> a TEST_DEPENDS is needed here >> >> >> >> >> >> >> >> >> A few changes are needed in pkg/PLIST too >> >> >> >> >> >> - remove share/doc/rss2email3/README, because the README from >> >> >> pkg/README >> >> >> will be automatically put there-> >> >> >> share/doc/pkg-readmes/${FULLPKGNAME} >> >> >> - ${MODPY_COMMENT} should be used for directories containing >> >> >> ${MODPY_PYCACHE} >> > >> > That's not really needed here, it's python3+ only. >> > >> >> > >> >> > Made these changes. Tarball attached. >> >> >> >> The port looks good to me, the transition path makes sense I guess... >> >> >> >> Two questions: >> >> >> >> 1. This proposal embeds "3" in the port directory name and the PKGNAME, >> >> what is supposed to happen with rss2email-4.0? A new mail/rss2email4 >> >> port? :) >> > >> > Has anyone figured out the process needed to move from aaronsw (RIP)'s >> > rss2email code that we have in ports now to this version? There was a >> > comment earlier that having the two in tree together made this easier >> > but no indication how. It would seem sensible to just have a one-time >> > bump to move across and avoid complexity. >> >> I would prefer this approach too. I thought you were an rss2email user. >> Did you try the instructions in pkg/README? > > Aargh I missed that :) > > So with a replacement, README is too late, but we can add to current.html > and upgrade notes. Something like this should work.. > > - Make a note of the default email address (r2e list | grep ^default) > - Export the list of feeds (r2e opmlexport > r2e.opml) > - Send any updates to feeds with the old version (r2e run) > - Update the package > - Create a new database (r2e new) > - Set the default email (r2e email "[email protected]") > - Import the list of feeds (r2e opmlimport < r2e.opml) > - Ignore old updates (r2e run --no-send), or if you don't mind duplicates > and want to be sure you didn't miss any, re-send everything (r2e run). > > Then I hit a runtime problem though... > > $ r2e run > sax parsing error: <unknown>:104:121: undefined entity: feed-1 > (http://www.undeadly.org/cgi?action=rss -> [email protected]) > Traceback (most recent call last): > File "/usr/local/bin/r2e", line 5, in <module> > rss2email.main.run() > File "/usr/local/lib/python3.6/site-packages/rss2email/main.py", line 163, > in run > args.func(feeds=feeds, args=args) > File "/usr/local/lib/python3.6/site-packages/rss2email/command.py", line > 62, in run > feed.run(send=args.send) > File "/usr/local/lib/python3.6/site-packages/rss2email/feed.py", line 838, > in run > for (guid, id_, sender, message) in self._process(parsed): > File "/usr/local/lib/python3.6/site-packages/rss2email/feed.py", line 357, > in _process > processed = self._process_entry(parsed=parsed, entry=entry) > File "/usr/local/lib/python3.6/site-packages/rss2email/feed.py", line 470, > in _process_entry > for k,v in extra_headers.items(): # remove empty tags, etc. > RuntimeError: OrderedDict mutated during iteration
Patch from upstream attached to work around this.
patch-rss2email_feed_py
Description: Binary data
This is at least the second unreleased fix I noticed for newer python3+ versions. This begs the question as to how this newer version is better than what we already have in ports... I get a warning using undeadly but no fatal crash: russell /usr/ports/mystuff/mail/rss2email3$ r2e3 run sax parsing error: <unknown>:104:121: undefined entity: undeadly (http://www.undeadly.org/cgi?action=rss -> [email protected]) I received the mail below: --8<-- From: "OpenBSD Journal: <author>" <[email protected]> Subject: To: [email protected] Date: Fri, 11 May 2018 16:11:23 -0000 (11 minutes, 35 seconds ago) User-Agent: rss2email/3.9 (https://github.com/wking/rss2email) URL: None -->8-- then mails for the p2k18 reports from landry@, naddy@, stsp@ and eric@ followed. I get the same warnings, and the same mostly empty mail in subsequent runs. >> There's also >> https://github.com/rss2email/rss2email/commit/375404478410e12fd497d4f11bf7c7050e4eb907 >> which I find "funny". Probably not many users rely on SSL/TLS. > > Probably not for smtp.. Yep. -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
