On 2018/06/12 16:34, Elias M. Mariani wrote:
> > +WANTLIB = #empty
> > +RUN_DEPENDS = #empty
> > +LIB_DEPENDS = #empty
> >
> > - it's a noop, but leave these as they were. just set RUN_DEPENDS-docs to
> > empty
> > and let -main inherit from the default. and WANTLIB/LIB_DEPENDS aren't set
> > by default anyway so no need to override, just set them for -main.
>
> Are you sure that RUN_DEPENDS-docs and WANTLIB-docs overrides
> RUN_DEPENDS and WANTLIB ?
yes, but you don't need to believe me. use 'make show=<variable>'.
> I had a problem with that, because py-sqlalchemy-docs must not be
> dependable on python2.7 or python3.6m.
>
> > +BUILD_DEPENDS = #empty
> > +BUILD_DEPENDS-main = ${_MODPY_BUILD_DEPENDS}
> > ..
> > # Other DB connectors would work, too.
> > -TEST_DEPENDS = devel/py-test-xdist${MODPY_FLAVOR} \
> > +TEST_DEPENDS-main = devel/py-test-xdist${MODPY_FLAVOR} \
> > devel/py-mock${MODPY_FLAVOR}
> > # On python3, sqlite3 is used.
> > -.if ${FLAVOR} == ""
> > -TEST_DEPENDS += databases/py-sqlite2${MODPY_FLAVOR}>=2.8.3
> > +.if empty (FLAVOR)
> > +TEST_DEPENDS-main += databases/py-sqlite2${MODPY_FLAVOR}>=2.8.3
> > .endif
> >
> > - these are bogus, BUILD_DEPENDS and TEST_DEPENDS relate to the whole port.
> > subpackages are split only in packaging.
>
> True.
>
> > +.if ${FLAVOR:Mpython3}
> > +FULLPKGNAME-main = py3-sqlalchemy-${MODPY_EGG_VERSION:S/p/./}
> > +FULLPKGPATH-main = databases/py-sqlalchemy${MODPY_FLAVOR}
> > +.endif
> >
> > - leave FULLPKG*-main at the default, you only want to override
> > FULLPKG*-docs.
>
> Wouldn't that produce:
> py-sqlalchemy-1.2.7p0-python3.tgz
> or
> py-sqlalchemy-1.2.7p0-main-python3.tgz?
no, set that in PKGNAME-main. (you can use MODPY_PY_PREFIX to get py- vs py3-).
> > - also missing the @pkgpath marker needed in PLIST-main to allow upgrades to
> > work. you can test by installing the old ones from a snap, building new
> > packages
> > and trying to upgrade with 'env TRUSTED_PKG_PATH=/path/to/new/packages
> > PKG_PATH=/path/to/new/packages pkg_add -u'.
>
> OK, reading the docs... about @pkgpath...
