On 06/14/18 08:39, Elias M. Mariani wrote:
Added test with py-test.
All regression test passing.

2018-06-13 19:41 GMT-03:00 Elias M. Mariani <marianiel...@gmail.com>:
Now I feel shame...
Thanks stuart. :D

2018-06-13 19:33 GMT-03:00 Stuart Henderson <s...@spacehopper.org>:
On 2018/06/13 16:00, Elias M. Mariani wrote:
1) add whitespace around variables, "COMMENT=" -> "COMMENT ="

OK, I saw examples in both ways so I didn't think it matters, but if
that is the convention, no problem.


whichever way you do it, "FLAVOR? =" isn't correct, it should either be 
"FLAVOR?="
or "FLAVOR ?=".


Hi,

sound good to me.

I would remove the commented BUILD_DEPENDS, if we don't build doc.

Thanks,

Remi.

Reply via email to