On Mon, Jun 25, 2018 at 10:04:24PM +0200, Landry Breuil wrote:
> On Mon, Jun 25, 2018 at 05:21:48PM +0300, Leonid Bobrov wrote:
> > Hi!
> > 
> > This is engine's bugfix release, minetest_game didn't change.
> > 
> > I hope this time I won't have to send more diffs:
> 
> Thanks, i've commited your diff. If you want to take maintainership or
> do more work on this port there's some room for improvement:
> - subpackage the server in a distinct package

In that case to avoid conflicts I need to package minetest_game too,
also is it a good idea to make minetest_game optional dependency for
both client and server like FreeBSD ports already did it?
(actually they made client/server/both dependencies of minetest_game,
I can't do that because unlike them I'll separate game and server)

Also I need to check if client and server as separate packages have
conflicts in PLIST.

> - fix the system libgmp detection in cmake/findGMP.cmake
> - the port doesnt respect the default cflags, which are -O2 -pipe. At
>   least they stopped doing the crazy -O3 -funroll-loops dance..
> 
> Landry
> 

Reply via email to