On Mon, Nov 26, 2018 at 11:05:45PM -0500, Brian Callahan wrote: > Hi ports -- > > For some reason, the gcc package doesn't install the stdatomic.h header. > Which doesn't matter, until it matters. > > Discovered when I was building Firefox on amd64 with gcc-6.4.0 (which works > at runtime just fine, but is not a discussion to be had on this thread > because it's way more involved than this simple diff). Firefox needs > stdatomic.h when using gcc, and this diff lets Firefox build successfully.
I'm not sure why (since you dont show the failure log :), https://dxr.mozilla.org/mozilla-release/source/media/ffvpx/config_unix64.h#233 is one of the few occurences. Note the comment in the libvpx header here: https://dxr.mozilla.org/mozilla-release/source/media/libvpx/libvpx/vpx_util/vpx_atomics.h#22 > OK? Better solution within the gcc framework itself? As for the gcc diff itself, i think there's a reason it's not installed, be it on purpose upstream (installing it only on supported platforms ?) or because some configure check fails for some reason on OpenBSD and then it's not installed. Side-installing it this way feels awkward.. Maybe looking at other oses might give a clue, per https://www.freshports.org/devel/amd64-gcc/ it is installed/shipped on FreeBSD, but i dunno if it's an upstream choice or a packaging choice. Landry
