On Wed, Jan 02, 2019 at 04:26:22PM +0100, Matthias Kilian wrote:
> Hi,
>
> On Sat, Dec 29, 2018 at 10:03:30PM +0100, Matthias Kilian wrote:
> > On Thu, Dec 27, 2018 at 06:03:40PM +0000, Edd Barrett wrote:
> > > The double comma thing: I thought that was a typo which happened
> > > to work, but I'm willing to be proven wrong!
> >
> > I think it was some copy&paste thing from the past. Some tools did
> > (still do) output more than just one comma for flavors, but
> > poppler,-qt5 (with just one comma) is perfectly ok.
>
> Looks like I was wrong... when poppler and poppler-qt5 are already
> installed, everything is fine, but if they aren't, you get this:
>
> ===> Verifying install for poppler-qt5-* in print/poppler
> ===> poppler-qt5-0.72.0 Ignored as FLAVOR contains no_qt5 .
>
> The diff below changes two things:
>
> Fix poppler-qt5 dependency -- I was wrong in that a single comma
> before -qt5 is enough.
>
> While here, move print/texlive/base from RUN_DEPENDS-main to
> LIB_DEPENDS-main, because WANTLIB contains synctex.
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/editors/texworks/Makefile,v
> retrieving revision 1.42
> diff -u -p -r1.42 Makefile
> --- Makefile 30 Dec 2018 12:11:56 -0000 1.42
> +++ Makefile 2 Jan 2019 15:20:41 -0000
> @@ -48,14 +48,14 @@ LIB_DEPENDS = ${MODQT5_LIB_DEPENDS} \
> x11/qt5/qtscript
> LIB_DEPENDS-main = ${LIB_DEPENDS} \
> textproc/hunspell \
> - print/poppler,-qt5
> + print/texlive/base \
> + print/poppler,,-qt5
> LIB_DEPENDS-lua = ${LIB_DEPENDS} \
> ${MODLUA_LIB_DEPENDS}
> LIB_DEPENDS-python = ${LIB_DEPENDS} \
> ${MODPY_LIB_DEPENDS}
>
> -RUN_DEPENDS-main = print/texlive/base \
> - devel/desktop-file-utils
> +RUN_DEPENDS-main = devel/desktop-file-utils
> RUN_DEPENDS-lua = editors/texworks,-main
> RUN_DEPENDS-python = editors/texworks,-main
>
> ok?
I think it needs a REVISION bump but otherwise ok :)
