Hi, (lots of things sniped)
On Fri, 22 Feb 2019 09:34:46 +0100 Landry Breuil wrote: > audio/p5-Audio-MPD/patches/patch-lib_Audio_MPD_Types_pm should be > removed, applied upstream. Thanks a lot, i've forgotten to 'cvs rm' it when doing the original update 5 months ago and didn't remember. So here is a new diff. > I dunno if the dependency on Audio-MPD-Common-2.003 should be > enforced, since upstream says there's no breaking changes.. but the > major version bump might say the contrary. You're right, i think JQUELIN has just not thought about changing META stuff, see [1] where he recommends moving everything to 2.x. So i changed accordingly. > I noticed that it had a dependency on List::Utils 1.45 - 1.50 is in > base only since the 5.28 update it seems, but that's fine for > -current - it just complains with the 1.42 that was in 6.4 before. In fact it requires devel/p5-List-AllUtils, that has been imported a week ago, after Perl 5.28. The situation is similar to the GeoIP2 stack. > On Fri, Feb 22, 2019 at 09:10:57AM +0100, Landry Breuil wrote: > t/00-report-prereqs.t .... ok > Could not create socket: No route to host > # Looks like you planned 20 tests but ran 3. > t/20-connection.t ........ > Dubious, test returned 255 (wstat 65280, 0xff00) > Failed 17/20 subtests > (less 1 skipped subtest: 2 okay) > > (and the other tests pass) > If you can reproduce it consistently, tell me how, because no matter how hard i try, i can't. If that's the case, can you please send the output of: cd `make show=WRKSRC` && ./Build test verbose=1 Charlène. [1] https://rt.cpan.org/Public/Bug/Display.html?id=91082#txn-1374402 Index: Makefile =================================================================== RCS file: /cvs/ports/audio/p5-Audio-MPD/Makefile,v retrieving revision 1.28 diff -u -p -u -p -r1.28 Makefile --- Makefile 20 Mar 2016 19:56:06 -0000 1.28 +++ Makefile 22 Feb 2019 18:38:30 -0000 @@ -1,8 +1,7 @@ # $OpenBSD: Makefile,v 1.28 2016/03/20 19:56:06 naddy Exp $ COMMENT= module for communicating with MPD servers -DISTNAME= Audio-MPD-1.110560 -REVISION= 3 +DISTNAME= Audio-MPD-2.004 CATEGORIES= audio # perl @@ -10,18 +9,24 @@ PERMIT_PACKAGE_CDROM= Yes MODULES= cpan PKG_ARCH= * -CPAN_AUTHOR= JQUELIN MODCPAN_EXAMPLES= Yes +MODCPAN_EXAMPLES_DIST= examples CONFIGURE_STYLE= modbuild -RUN_DEPENDS= audio/p5-Audio-MPD-Common>=1.110550 \ - devel/p5-MooseX-Has-Sugar \ - devel/p5-MooseX-SemiAffordanceAccessor>=0.09 \ - devel/p5-Class-Accessor \ +RUN_DEPENDS= audio/p5-Audio-MPD-Common>=2.003 \ devel/p5-Getopt-Euclid \ + devel/p5-List-AllUtils \ + devel/p5-List-MoreUtils \ + devel/p5-Moose \ + devel/p5-MooseX-Has-Sugar \ + devel/p5-MooseX-SemiAffordanceAccessor \ devel/p5-Proc-Daemon -TEST_DEPENDS= devel/p5-Getopt-Euclid \ - devel/p5-Test-Corpus-Audio-MPD + +TEST_DEPENDS= devel/p5-Test-Corpus-Audio-MPD>=1.113282 + +# Tests need to find mpd. +pre-test: + @ln -sf ${LOCALBASE}/sbin/mpd ${WRKDIR}/bin/mpd .include <bsd.port.mk> Index: distinfo =================================================================== RCS file: /cvs/ports/audio/p5-Audio-MPD/distinfo,v retrieving revision 1.13 diff -u -p -u -p -r1.13 distinfo --- distinfo 17 Apr 2014 20:51:25 -0000 1.13 +++ distinfo 22 Feb 2019 18:38:30 -0000 @@ -1,2 +1,2 @@ -SHA256 (Audio-MPD-1.110560.tar.gz) = EnQIRIdGxv58uweer9ZRC7IZLneZ2BAeBDts/BQK39M= -SIZE (Audio-MPD-1.110560.tar.gz) = 36121 +SHA256 (Audio-MPD-2.004.tar.gz) = xPit/gQNU3PdyaM9umbqEI0C5FF4uOYPXPdKpAjGqpI= +SIZE (Audio-MPD-2.004.tar.gz) = 41586 Index: pkg/PLIST =================================================================== RCS file: /cvs/ports/audio/p5-Audio-MPD/pkg/PLIST,v retrieving revision 1.5 diff -u -p -u -p -r1.5 PLIST --- pkg/PLIST 29 Sep 2010 17:19:30 -0000 1.5 +++ pkg/PLIST 22 Feb 2019 18:38:30 -0000 @@ -1,10 +1,12 @@ @comment $OpenBSD: PLIST,v 1.5 2010/09/29 17:19:30 jasper Exp $ +bin/mpd-dump-ratings bin/mpd-dynamic bin/mpd-rate ${P5SITE}/Audio/MPD.pm ${P5SITE}/Audio/MPD/Collection.pm ${P5SITE}/Audio/MPD/Playlist.pm ${P5SITE}/Audio/MPD/Types.pm +@man man/man1/mpd-dump-ratings.1 @man man/man1/mpd-dynamic.1 @man man/man1/mpd-rate.1 @man man/man3p/Audio::MPD.3p Index: patches/patch-lib_Audio_MPD_Types_pm =================================================================== RCS file: patches/patch-lib_Audio_MPD_Types_pm diff -N patches/patch-lib_Audio_MPD_Types_pm --- patches/patch-lib_Audio_MPD_Types_pm 17 Apr 2014 20:51:25 -0000 1.1 +++ /dev/null 1 Jan 1970 00:00:00 -0000 @@ -1,16 +0,0 @@ -$OpenBSD: patch-lib_Audio_MPD_Types_pm,v 1.1 2014/04/17 20:51:25 landry Exp $ - -https://rt.cpan.org/Public/Bug/Display.html?id=90682 -https://github.com/zoffixznet/audio-mpd/commit/7eb61ed18732cb2b7592b01b0ac2e1aa705f3a13 - ---- lib/Audio/MPD/Types.pm.orig Thu Apr 17 08:07:31 2014 -+++ lib/Audio/MPD/Types.pm Thu Apr 17 08:07:43 2014 -@@ -18,7 +18,7 @@ package Audio::MPD::Types; - - use Moose::Util::TypeConstraints; - --enum CONNTYPE => qw{ reuse once }; -+enum CONNTYPE => [qw{ reuse once }]; - - 1; -
