On Fri Mar 01, 2019 at 08:27:43AM +0000, Stuart Henderson wrote:
> On 2019/03/01 06:56, Rafael Sadowski wrote:
> > libxml is not in WANTLIB (also after update) but there is a CMake check
> > at configure-time. Added NO_TEST=Yes, while here.
>
> What's the story with libxml here? It has a cmake check but doesn't seem
> to be used?
Exactly! There is a check in the main ./CMakeLists.txt and only one
include (include_directories) in ./gstreamer/CMakeLists.txt.
"LibXml2 is required to compile the gstreamer backend for Phonon"
^^^^^^^
>
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/multimedia/phonon-backend/gstreamer/Makefile,v
> > retrieving revision 1.22
> > diff -u -p -u -p -r1.22 Makefile
> > --- Makefile 19 Oct 2018 20:53:27 -0000 1.22
> > +++ Makefile 20 Feb 2019 05:23:26 -0000
> > @@ -27,9 +27,9 @@ RUN_DEPENDS-main = multimedia/gstreamer1
> >
> > LIB_DEPENDS-icons =
> > LIB_DEPENDS-main = ${LIB_DEPENDS} \
> > - textproc/libxml \
> > multimedia/gstreamer1/core \
> > multimedia/gstreamer1/plugins-base
> > +LIB_DEPENDS-build = textproc/libxml
>
> There is no -build subpackage.
Ops local jetlag ;) s/+LIB_DEPENDS-build/+BUILD_DEPENDS/
>
> Changing runtime dependencies requires a REVISION bump.
>
ACK;
