On 2019/03/03 13:20, Rafael Sadowski wrote:
> On Fri Mar 01, 2019 at 08:48:54PM +0000, Stuart Henderson wrote:
> > On 2019/03/01 12:53, Rafael Sadowski wrote:
> > > On Fri Mar 01, 2019 at 08:27:43AM +0000, Stuart Henderson wrote:
> > > > On 2019/03/01 06:56, Rafael Sadowski wrote:
> > > > > libxml is not in WANTLIB (also after update) but there is a CMake
> > > > > check
> > > > > at configure-time. Added NO_TEST=Yes, while here.
> > > >
> > > > What's the story with libxml here? It has a cmake check but doesn't seem
> > > > to be used?
> > >
> > > Exactly! There is a check in the main ./CMakeLists.txt and only one
> > > include (include_directories) in ./gstreamer/CMakeLists.txt.
> > >
> > > "LibXml2 is required to compile the gstreamer backend for Phonon"
> > > ^^^^^^^
> >
> > Yes I see the check - but I don't see where it is used.
> >
>
> gstreamer/CMakeLists.txt line 23 "${LIBXML2_INCLUDE_DIR}" Anyway I can't
> build phonon-qt5-gstreamer-4.9.0-qt5 without libxml2 on my system
> because it's comes from qt5-base.
>
> RS
>
Again: I don't see where it is used. None of the files in
include/libxml2/libxml are pulled in by phonon-backend-gstreamer build
(you can test this easily, move the directory out the way after make configure).
So it seems like it is a useless check in CMakeLists.txt.
I don't object to the BUILD_DEPENDS but if it's really a useless check
then it would be nicer if the check (and dependency) wasn't there, it would
be one less thing to check if someone updates libxml.
