On Sun, Mar 03, 2019 at 02:01:55PM +0000, Stuart Henderson wrote: > On 2019/03/03 14:45, Stefan Sperling wrote: > > Attached is a port of libdbus-c++. > > > > I need this for an upcoming port of TextSuggest, which I'll mail out > > soon, too. > > > > OK? > > > > Please start from > > SHARED_LIBS = dbus-c++-1 0.0 > > ..mostly so we can see that the version number is properly under control > of ports infrastructure. And please add > > COMPILER = base-clang ports-gcc base-gcc > > so that it's built against the same C++ standard library as other ports > (this is generally needed for all C++ ports unless there are special > circumstances, mostly things on the path to building ports-gcc). > > Otherwise OK. >
Here's a new version with some changes on top of your suggestions: 1) Add more patches, and add comments to all patches. In particular, fix poll(2) event mask which resulted in unhandled POLLHUP events in the main event loop which made textsuggest-server spin on the CPU. As far as I understand, the "unlock" file descriptors are only interested in POLLIN events. They can be triggered to wake the event loop while a thread sleeps in poll(2). This feature is used by the library's teardown code. POLLOUT makes no sense here. textsuggest uses much less CPU becomes a lot more responsive with this fix. 2) Enable glib integration. This adds another shared library which is not used by textsuggest but will perhaps be useful if other consumers of libdbus-c++ show up. 3) Run regression test (there's just one, the others are just empty stubs). Still OK?
libdbus-c++.tar.gz
Description: application/tar-gz
