On Tue, Mar 12, 2019 at 08:56:07PM +0000, Stuart Henderson wrote: > On 2019/03/12 20:44, Klemens Nanni wrote: > > WANTLIB and USE_GMAKE have a space after "=". > > Please break LIB_DEPENDS into one port per line. > > +1 > > It gained a BUILD_DEPENDS on gtk2mm, but it's only actually used in > one of the examples (disabled via CONFIGURE_ARGS) and they don't actually > build (for another reason) if you enable them. > > I think I would drop the gtk2mm dependency; as-is, if it changes to being > a library dependency rather than just a build dependency in the future, > it wouldn't be noticed in bulk builds.
Thanks both of you. All your suggestions should be addressed in the attached version. The gtk2mm dependency has been dropped but the configure script is still checking for it. I've verified that it compiles with and without the gtk2mm package installed. > > As per the project's README, `--enable-debug' should be passed for extra > > "debugging code", so you could add that to CONFIGURE_ARGS if DEBUG is > > set in case anyone cares to hack on using this port. The README is lying. The configure script has no such option.
libdbus-c++.tar.gz
Description: application/tar-gz
