Alessandro DE LAURENZIS writes:
> Dear ports@ readers,
>
> this is a proposal for a new port: netgen 1.5.118, a tool for netlist
> comparison (LVS) and format manipulation.
...
> # GPLv1
Wow, don't see that very often.
> CONFIGURE_ARGS +=
= is fine. (You can check with "make show=CONFIGURE_ARGS".)
> CFLAGS = -std=c89
This will break if CFLAGS is set in mk.conf or on the command line.
$ make CFLAGS=-Dfoo
(snip)
../base/objlist.h:270:39: error: expected ')'
(snip)
*** Error 1 in /ptmp/mystuff/cad/netgen
(/ptmp/ports/infrastructure/mk/bsd.port.mk:2467 'all')
> + CFLAGS="${CFLAGS} -I/usr/X11R6/include"
Should use ${X11BASE}. Since that's a make variable (not visible to the
configure script), that means running ${SUBST_CMD} on the patched file
to perform the substitution. It's kind of a hassle.
So how about this instead:
CONFIGURE_ENV = CPPFLAGS="-I${X11BASE}/include" \
CFLAGS="-std=c89 ${CFLAGS}"
With this minor fix, the port looks fine to me.
--
Anthony J. Bentley
