Anthony, Stuart, thanks for your feedback
On 19/03/2019 18:01, Stuart Henderson wrote:
On 2019/03/19 02:07, Anthony J. Bentley wrote:
[...]
CONFIGURE_ARGS +== is fine. (You can check with "make show=CONFIGURE_ARGS".)
fixed
CFLAGS = -std=c89This will break if CFLAGS is set in mk.conf or on the command line. $ make CFLAGS=-Dfoo (snip) ../base/objlist.h:270:39: error: expected ')' (snip) *** Error 1 in /ptmp/mystuff/cad/netgen (/ptmp/ports/infrastructure/mk/bsd.port.mk:2467 'all')+ CFLAGS="${CFLAGS} -I/usr/X11R6/include"Should use ${X11BASE}. Since that's a make variable (not visible to the configure script), that means running ${SUBST_CMD} on the patched file to perform the substitution. It's kind of a hassle. So how about this instead: CONFIGURE_ENV = CPPFLAGS="-I${X11BASE}/include" \ CFLAGS="-std=c89 ${CFLAGS}"If that works that's the right way to do it.
Modified as per your suggestion. I'll probably update soon other ports (magic, qrouter, ...) using the same style.
With this minor fix, the port looks fine to me.Rest is OK with me. Personally I wouldn't bother patching away the echo's in configure though.
I removed the CFLAGS definition in script/configure, but still patched away the echo lines (for me the message is misleading and I made the same for some other ports); hope this is acceptable.
Updated tarball attached. -- Alessandro DE LAURENZIS [mailto:[email protected]] Web: http://www.atlantide.t28.net LinkedIn: https://www.linkedin.com/in/delaurenzis/
netgen.tar.gz
Description: application/gzip
