On 2019/03/25 15:22, Renaud Allard wrote:
> Hello,
> 
> Here is a port for mail/opendmarc, this will allow the use of the library in
> other mail programs.
> 
> Best Regards
> 

Comments from a quick read through

- one entry per line in LIB_DEPENDS please

- "LIB_DEPENDS mail/libspf2 not needed for mail/opendmarc ?"
  -> see DIAGNOSTICS in bsd.port.mk(5)

- there's an empty share/examples/opendmarc/ in PLIST (which isn't
  created by the port build, so packaging fails)

- some config samples are in share/doc/opendmarc/

- DESCR could do with more information about what's included in the
  package and less about the sponsors

- missing user/group and rc script for the daemon

Reply via email to