On 2019/03/25 16:20, Renaud Allard wrote:
>
>
> On 3/25/19 3:31 PM, Stuart Henderson wrote:
> > On 2019/03/25 15:22, Renaud Allard wrote:
> > > Hello,
> > >
> > > Here is a port for mail/opendmarc, this will allow the use of the library
> > > in
> > > other mail programs.
> > >
> > > Best Regards
> > >
> >
> > Comments from a quick read through
> >
> > - one entry per line in LIB_DEPENDS please
> >
> > - "LIB_DEPENDS mail/libspf2 not needed for mail/opendmarc ?"
> > -> see DIAGNOSTICS in bsd.port.mk(5)
> >
> > - there's an empty share/examples/opendmarc/ in PLIST (which isn't
> > created by the port build, so packaging fails)
> >
> > - some config samples are in share/doc/opendmarc/
> >
> > - DESCR could do with more information about what's included in the
> > package and less about the sponsors
> >
> > - missing user/group and rc script for the daemon
> >
>
> I have attached a better one which also needs:
> --- infrastructure/db/user.list 7 Mar 2019 20:59:29 -0000 1.339
> +++ infrastructure/db/user.list 25 Mar 2019 15:04:52 -0000
> @@ -341,3 +341,4 @@ id user group port options
> 830 _pdns_recursor _pdns_recursor net/powerdns_recursor
> 831 _dicod _dicod net/dico
> 832 _litecoind _litecoind net/litecoin
> +833 _opendmarc _opendmarc mail/opendmarc
Getting there; couple of small things
- don't hardcode _opendmarc in the rc script, use ${daemon_user}
- missing $OpenBSD$ line in rc script
I haven't tried building it yet.
