Mikolaj Kucharski <miko...@kucharski.name> writes:
Hi,
> On Thu, Apr 11, 2019 at 08:16:02PM +0200, Grégoire Jadi wrote:
>> Mikolaj Kucharski <miko...@kucharski.name> writes:
>>
>> > Hi,
>>
>> Hi Mikolaj,
>>
>> Thanks for the patch and sorry for the long delay.
>>
>> The patch looks fine and works for my usecases.
>>
>> However, I can't generate a working gpg key with `genkeys gpg'. The gpg
>> passphrase is generated, the pub key too. But, the private key is empty.
>> The following command returns nothing:
>>
>> keyringer <keyring> decrypt mygpg
>>
>> Is that expected? Does it works for you?
>>
>>
>> Best,
>>
>
> No, it doesn't work for me too, however I think I'm facing even
> different issue. With 0.5.3, I had problem mentioned in changelog, now I
> see something different. I'm not sure is the problem with keyringer,
> bash or I'm doing something wrong, as I see empty public and private
> exported keyfile after:
>
> keyringer mytestkeyring genkeys gpg examplefile examplehost outputfile
>
> I also see bash.core in current working directory and I've stopped there
> as I don't have time to dive deeper into this.
>
> I want to look more into keyringer, but I don't have enough time at
> present, to do proper analysis. Sorry :/
So for the time being I suggest we go ahead with your patch. We will
fix the gpg keygen when we can.
Ok to commit for me.
Best,
Index: Makefile
===================================================================
RCS file: /cvs/ports/security/keyringer/Makefile,v
retrieving revision 1.4
diff -u -p -u -r1.4 Makefile
--- Makefile 16 Jun 2018 11:47:06 -0000 1.4
+++ Makefile 21 Mar 2019 09:54:18 -0000
@@ -2,8 +2,7 @@
COMMENT = manage and share secrets using GnuPG and Git
-DISTNAME = keyringer-0.5.3
-REVISION = 1
+DISTNAME = keyringer-0.5.4
CATEGORIES = security
Index: distinfo
===================================================================
RCS file: /cvs/ports/security/keyringer/distinfo,v
retrieving revision 1.2
diff -u -p -u -r1.2 distinfo
--- distinfo 1 Jun 2018 11:50:17 -0000 1.2
+++ distinfo 21 Mar 2019 09:54:18 -0000
@@ -1,2 +1,2 @@
-SHA256 (keyringer-0.5.3.tar.bz2) = ikpdp87ldzL9nXBWSZwAIKJi9r7N05cW24EXIucLerU=
-SIZE (keyringer-0.5.3.tar.bz2) = 78371
+SHA256 (keyringer-0.5.4.tar.bz2) = RdwF92+wh5fTgP8oQadM7sYZNs+uIhnQW5a3cz40n4M=
+SIZE (keyringer-0.5.4.tar.bz2) = 80907
Index: patches/patch-lib_keyringer_functions
===================================================================
RCS file: /cvs/ports/security/keyringer/patches/patch-lib_keyringer_functions,v
retrieving revision 1.3
diff -u -p -u -r1.3 patch-lib_keyringer_functions
--- patches/patch-lib_keyringer_functions 3 Jun 2018 15:39:24 -0000
1.3
+++ patches/patch-lib_keyringer_functions 21 Mar 2019 09:54:18 -0000
@@ -19,11 +19,11 @@ Index: lib/keyringer/functions
fi
if [ ! -z "$KEYID" ]; then
-- GPG="gpg --quiet -u $KEYID"
-+ GPG="gpg2 --quiet -u $KEYID"
+- GPG="gpg --quiet --no-encrypt-to -u $KEYID"
++ GPG="gpg2 --quiet --no-encrypt-to -u $KEYID"
else
-- GPG="gpg --quiet"
-+ GPG="gpg2 --quiet"
+- GPG="gpg --quiet --no-encrypt-to"
++ GPG="gpg2 --quiet --no-encrypt-to"
fi
# Check keyring config version
--
