On Wed, Jul 10, 2019 at 01:53:49PM +0100, Stuart Henderson wrote:
> On 2019/07/10 13:52, Björn Ketelaars wrote:
> > Please find enclosed a port for xxhash.
> > 
> > DESCR:
> > xxHash is an extremely fast non-cryptographic hash algorithm, running at
> > RAM speed limits. Code is highly portable, and hashes are identical on
> > all platforms (little / big endian).
> 
> "non-cryptographic hash algorithm", security/ feels wrong, though
> I'm not sure what is better ..

sysutils?

BTW, looks good to me.

> 
> > I disabled a test for now as it irreproducible errors out, and I'm
> > unable to fix it. Run tested in combination with HEAD of borgbackup.
> 
> it's better if failing tests are visible so I wouldn't disable it.
> (Though that test seems to pass reliably for me anyway..)
> 

-- 
Juan Francisco Cantero Hurtado http://juanfra.info

Reply via email to