On Fri, 1 Nov 2019 16:45:36 +0000 Tom Murphy wrote: > On Thu, Oct 24, 2019 at 09:27:29PM +0200, Charlene Wendling wrote: > > On Wed, 23 Oct 2019 09:17:16 +0100 > > Tom Murphy wrote: > > > > > On 2019-10-22 18:17, Charlene Wendling wrote: > > > > Hi ports, Tom, > > > > > > > >> http://build-failures.rhaalovely.net/powerpc/2019-09-17/games/freeorion.log > > > > > > > > On base-clang archs, the game is built with the default -O2, > > > > but on base-gcc ones, it's built with -O3. On sparc64 it seems > > > > not to be an issue, but on macppc, it's causing an OOM error. > > > > > > > > On my macppc machine (2GB ram + 2GB swap) it builds (and swaps) > > > > fine [0]. > > > > The runtime is very slow, i've load averages > 20, but afaik > > > > it's not a reason to mark it BROKEN :) > > > > > > > > Comments/feedback are welcome, > > > > > > > > Charlène. > > > > > > > > > > > > [0] https://bin.charlenew.xyz/freeorion.log > > > > > > > > > > > > Index: Makefile > > > > =================================================================== > > > > RCS file: /cvs/ports/games/freeorion/Makefile,v > > > > retrieving revision 1.3 > > > > diff -u -p -u -p -r1.3 Makefile > > > > --- Makefile 12 Jul 2019 20:46:18 -0000 1.3 > > > > +++ Makefile 22 Oct 2019 17:11:34 -0000 > > > > @@ -5,7 +5,7 @@ COMMENT = turn-based space empire and ga > > > > DISTNAME = FreeOrion_v${V}_2018-08-23.26f16b0_Source > > > > PKGNAME = freeorion-${V} > > > > CATEGORIES = games > > > > -REVISION = 0 > > > > +REVISION = 1 > > > > > > > > HOMEPAGE = https://www.freeorion.org/ > > > > MAINTAINER = Tom Murphy <[email protected]> > > > > Index: patches/patch-CMakeLists_txt > > > > =================================================================== > > > > RCS file: patches/patch-CMakeLists_txt > > > > diff -N patches/patch-CMakeLists_txt > > > > --- /dev/null 1 Jan 1970 00:00:00 -0000 > > > > +++ patches/patch-CMakeLists_txt 22 Oct 2019 17:11:34 > > > > -0000 @@ -0,0 +1,14 @@ > > > > +$OpenBSD$ > > > > +Remove hardcoded optimisation option. > > > > + > > > > +Index: CMakeLists.txt > > > > +--- CMakeLists.txt.orig > > > > ++++ CMakeLists.txt > > > > +@@ -394,7 +394,6 @@ target_compile_options(freeorionparseobj > > > > + $<$<CXX_COMPILER_ID:AppleClang>:-fvisibility=hidden> > > > > + $<$<CXX_COMPILER_ID:Clang>:-ftemplate-depth=512> > > > > + $<$<CXX_COMPILER_ID:AppleClang>:-ftemplate-depth=512> > > > > +- > > > > $<$<AND:$<NOT:$<BOOL:${BUILD_TESTING}>>, > > > > $<CXX_COMPILER_ID:GNU>>:-O3> > > > > + ) > > > > + > > > > + target_compile_definitions(freeorionparseobj > > > > > > Hi Charlène, > > > > > > The Makefile part of the diff doesn't apply cleanly. Is the > > > line numbering off? > > > > I've cleaned and checked out the whole port again and i don't meet > > that issue :| > > > > > Anyway, yes removing -O3 is good to me. > > > > > > Thanks, > > > Tom > > > > > Hi Charlène, > > I think there may have been something messed up with the formatting > when I saved it, I've re-tested with your diff and I've tested it and > it patches fine and compiles and runs for me! > > Thanks, > Tom >
Hi, I hoped a third person would rule this out because i didn't see where it could be wrong. I committed it, thanks for your feedback! Charlène.
