Hi all,

It took me longer than expected in getting around to incorporating
everybody's suggestions $day_job got in the way.

Hopefully I've addressed all concerns and questions.

I spent a bit of time digging into gpgme and it really does just
fork() 3 programs:
- gpgme-config
- gpgconf
- gnupg2
So I've create configure time checks (with the ability to disable),
and their full paths get passed to unveil().

Once question I have, should I be adding to the Makefile:

RUN_DEPENDS =           gnupg-*:security/gnupg

As this is what gpgme has? Although gpgme also has:

# Requires gpgsm (gnupg 2.x) during build, but can run with any gnupg.
BUILD_DEPENDS =         gnupg->=2:security/gnupg2

I worry that I am not indicating any explicit dependency on gnupg
and that dependency is coming in from gpgme. Which I think it means
it's OK, but I thought I might ask. Thanks!

Once again, I really appreciate all feedback!

Tim

Index: Makefile
===================================================================
RCS file: /cvs/ports/productivity/mcds/Makefile,v
retrieving revision 1.3
diff -u -p -r1.3 Makefile
--- Makefile	12 Jul 2019 20:48:59 -0000	1.3
+++ Makefile	28 Dec 2019 22:22:13 -0000
@@ -2,7 +2,7 @@
 
 COMMENT =		tty-based carddav search tool
 
-V =			0.9
+V =			1.4
 DISTNAME =		mcds-${V}
 CATEGORIES =		productivity
 REVISION =		0
@@ -12,13 +12,15 @@ MAINTAINER =		Timothy Brown <tbrown@free
 # GPLv3+
 PERMIT_PACKAGE =	Yes
 
-WANTLIB =		c curl iconv intl xml2
+# uses pledge()
+WANTLIB =		assuan c curl gpg-error gpgme iconv intl xml2
 
 MASTER_SITES =		https://github.com/t-brown/mcds/releases/download/v${V}/
 
 LIB_DEPENDS =		devel/gettext,-runtime \
 			net/curl \
-			textproc/libxml
+			textproc/libxml \
+			security/gpgme
 
 CONFIGURE_STYLE =	gnu
 
Index: distinfo
===================================================================
RCS file: /cvs/ports/productivity/mcds/distinfo,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 distinfo
--- distinfo	2 May 2019 15:52:58 -0000	1.1.1.1
+++ distinfo	28 Dec 2019 22:22:13 -0000
@@ -1,2 +1,2 @@
-SHA256 (mcds-0.9.tar.gz) = p+H8Q94kiHDDo/pV570uCXZki5YnyC41tUDx8HgARKc=
-SIZE (mcds-0.9.tar.gz) = 194620
+SHA256 (mcds-1.4.tar.gz) = nKLv7jvl1kWYBfP8HmBoWRTdJLZ2jrkiVGD/s8bsXQg=
+SIZE (mcds-1.4.tar.gz) = 202318
Index: pkg/DESCR
===================================================================
RCS file: /cvs/ports/productivity/mcds/pkg/DESCR,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 DESCR
--- pkg/DESCR	2 May 2019 15:52:58 -0000	1.1.1.1
+++ pkg/DESCR	28 Dec 2019 22:22:13 -0000
@@ -1,2 +1,2 @@
 Mcds is a command line tool primarily used as a search query plugin for mutt
-to query a carddav server.
+to query a CardDav server.

Reply via email to