On Sat, Dec 28, 2019 at 03:32:47PM -0700, Timothy Brown wrote:
> Hi all,
> 
> It took me longer than expected in getting around to incorporating
> everybody's suggestions $day_job got in the way.
> 
> Hopefully I've addressed all concerns and questions.
> 
> I spent a bit of time digging into gpgme and it really does just
> fork() 3 programs:
> - gpgme-config
> - gpgconf
> - gnupg2
> So I've create configure time checks (with the ability to disable),
> and their full paths get passed to unveil().
> 
> Once question I have, should I be adding to the Makefile:
> 
> RUN_DEPENDS =           gnupg-*:security/gnupg
> 
> As this is what gpgme has? Although gpgme also has:
> 
> # Requires gpgsm (gnupg 2.x) during build, but can run with any gnupg.
> BUILD_DEPENDS =         gnupg->=2:security/gnupg2
> 
> I worry that I am not indicating any explicit dependency on gnupg
> and that dependency is coming in from gpgme. Which I think it means
> it's OK, but I thought I might ask. Thanks!

yes, if you directly use gpgme, only declaring it as a dependency is
fine, the others will come with it. Personally i dont use this gpg fancy
stuff (so havent looked at the configure bits details, nor the
pledge/unveil stuff), but this new mcds version still works fine
querying my carddav server. Thanks!

Only nit: if you change the version, you can remove REVISION.
with that fixed, ok landry@

Landry

Reply via email to