On Thu, August 6, 2020 13:49, Landry Breuil wrote:
> On Thu, Aug 06, 2020 at 12:18:50PM +0300, Kirill Bychkov wrote:
>> On Sun, August 2, 2020 18:24, Paco Esteban wrote:
>> > On Sat, 01 Aug 2020, Stuart Henderson wrote:
>> >
>> >> On 2020/08/01 17:40, Paco Esteban wrote:
>> >> > On Sat, 01 Aug 2020, Landry Breuil wrote:
>> >> >
>> >> > > Hi,
>> >> > >
>> >> > > here's an update to goaccess 1.4 (cf
>> >> > > http://goaccess.io/release-notes#release-1.4), drops the tokyocabinet
>> >> > > flavor (dep dropped upstream), removed some patches from upstream, i
>> >> > > have to admit i'm a bit puzzled by the src/settings.c patch, upstream
>> >> > > code was modified a bit there.
>> >> > >
>> >> > > feedback/testing welcome !
>> >> >
>> >> > Tested with combined logs from httpd. On the config file I've
>> >> > uncommented:
>> >> >
>> >> > # httpd(8) combined log format
>> >> > date-format %d/%b/%Y
>> >> > time-format %T %z
>> >> > log-format %v %h %^ %^ [%d:%t] "%r" %s %b "%R" "%u"
>> >> >
>> >> > It crashes for me with this error:
>> >> >
>> >> > GoAccess - version 1.4 - Aug 1 2020 17:35:48
>> >> > Config file: No config file used
>> >> >
>> >> > Fatal error has occurred
>> >> > Error occurred at: src/goaccess.c - set_curses - 1411
>> >> > No time format was found on your conf file.
>> >> >
>> >> > I have to explicitly specify the config file with
>> >> > `--config-file=/etc/goaccess.conf`. After that it works fine. Could
>> it
>> >> > be related to that patch that you were talking about ?
>> >> >
>> >> > Cheers,
>> >> >
>> >> > --
>> >> > Paco Esteban.
>> >> > 0x5818130B8A6DBC03
>> >>
>> >> Oh, sounds like they messed up the fix afterwards then :(
>> >
>> > I think I've found the issue. I had to add a new patch to src/util.c.
>> > They were trying to get the config file from
>> > ${SYSCONFDIR}/goaccess/goaccess.conf and we put it on
>> > ${SYSCONFDIR}/goaccess.conf
>> >
>> > Here's the updated patch. With this it works fine for me on amd64.
>> >
>>
>> Hi,
>> Thanks for figuring this out. It works as before, using
>> my old config.
>> ok kirby@
>
> Just to make sure i got it right, are you okay with the patch changing
> the location upstream expects the config ? that changed in
> https://github.com/allinurl/goaccess/commit/6efcac6179859a504d60a7b96e2549e6da853c95
> where they default to a subdir of sysconfdir, and the code that looks
> for the config file changed in
> https://github.com/allinurl/goaccess/commit/91d3adaddd0a53cd23373f2ee1480de610bc4439.
>
> paco's patch would revert the latter. Isnt it cleaner to just modify
> where we @sample the default config file, adding a note to current.html
> telling users the default config file location changed ?
>
> Landry
>
Missed your previous mail.
I'm OK with moving config to /etc/goaccess/ as upstream have done.
Probably browsers.list could be @sampled here with the tweak to
config file setting its default location.
