Hi Evandro,

On Sun, 16 Aug 2020, Evandro Rathke wrote:

> Hi folks!
> I hope everyone is going well.
> 
> This is the port for Ultimaker Cura. Is an update for the latest stable
> version available.
> More info: https://gitlab.com/erathke/cura-port
> 
> Please, let me know if you have any issues.

First of all, thanks for your work on this.  It seems quite an effort
you took there.

I did not have the time to test it all yet, but I took a peek at your
ports.  Here are some comments and suggestions you should take a look.
More experienced porters may add/clarify stuff I say below.

Be patient, this is a lot of new ports in one go and review them takes
time.

So, a general comment, why not taking maintainer ?  This is a huge thing
that can rot very quickly.  It's not absolutely necessary, but make it
clear that you will take care of those ports make it more likely to get
imported.

For the py ports, you did not set MODPY_PYTEST.  Have you tried
regression tests for any of them ?

Then, some comments on the ports themselves:
    * cad/cura
        * MODULES goes before depends (check the Makefile template).
        * RUN_DEPENDS needs reorganization.  Alphabetically, first by
          category then by port name.
        * py ports on *_DEPENDS don't need the ',' before MODPY_FLAVOR
        * FLAVOR does not need the '+'
    * cad/cura-engine
        * MODULES goes before depends (check template).
        * RUN_DEPENDS needs reorganization
    * cad/fdm_materials
        * seems good at first sight.
    * cad/uranium
        * RUN_DEPENDS needs reorganization
        * FLAVOR does not need the '?'.  New ports py3 only, please.
        * py ports on *_DEPENDS don't need the ',' before MODPY_FLAVOR
        * you may want to review `patches/patch-UM_Platform_py`.  I think the
          comment on `isOpenBSD` is copy/pasted from another method.
        * also, comment your patches if possible, so somebody looking at
          them knows why they are there.
    * devel/libSavitar
        * MODULES goes before depends (check template).
        * FLAVOR does not need the '?'.  New ports py3 only, please.
        * py ports on *_DEPENDS don't need the ',' before MODPY_FLAVOR
        * I think you need a SHARED_LIBS here (bsd.port.mk(5)).
    * devel/py-colorlog
        * FLAVOR does not need the '?'.  New ports py3 only, please.
    * devel/py-pycollada
        * This is a library, I think it should follow the FLAVORS/FLAVOR schema
          and make it explicitly py3 only.
    * devel/py-trimesh
        * No need for that NEEDED_DEPENDS.  Define BUILD_DEPENDS and later
          RUN_DEPENDS = ${BUILD_DEPENDS}
        * In any case, dependencies need reorganization.
        * FLAVOR does not need the '?'.  New ports py3 only, please.
    * devel/stb
        * use ${INSTALL_DATA_DIR} instead of `mkdir -p`
        * probably ${INSTALL_DATA} instead of cp
        * who's that MAINTAINER ?
    * math/fcl
        * take a look at the order of variables.  SHARED_LIBS goes further up,
          MODULES too.  Take the Makefile template for reference.
    * math/libccd
        * again, take a look at the template for variable order
    * math/octomap
        * again, take a look at the template for variable order
    * math/py-fcl
        * No need for that NEEDED_DEPENDS.  I guess a bit of repeat here is
          fine, deps list is short.
        * In any case, dependencies need reorganization.
        * FLAVOR does not need the '?'.  New ports py3 only, please.
    * math/py-triangle
        * check PERMIT_PACKAGE and the license comment.  This seems to be
          LGPLv3.  So PERMIT_DISTFILES is not needed.
    * net/libArcus
        * py ports on *_DEPENDS don't need the ',' before MODPY_FLAVOR
        * FLAVOR does not need the '?'.  New ports py3 only, please.
        * again, take a look at the template for variable order
        * look at SHARED_LIBS on bsd.port.mk(5).  You should start with 0.0
    * net/libCharon
        * this one has some systemd references in PLIST.  Can we get ride of
          those or are they needed for something else ?
    * security/py-xxhash
        * FLAVOR does not need the '?'.  New ports py3 only, please.

I'll probably give it all a try towards the end of the week.
It would be nice to have a modern slicer on ports :-)

Cheers,

-- 
Paco Esteban.
0x5818130B8A6DBC03

Reply via email to