Hi folks!
Thank you for the feedback! As soon as possible I will take care of each
point. :D
Best regards,
Evandro Rathke
*Mobile/WhatsApp*: +55 51 9 9921-5584
*Skype*: erathke
On Tue, Aug 18, 2020 at 8:59 AM Stuart Henderson <s...@spacehopper.org>
wrote:
> On 2020/08/18 11:29, Stuart Henderson wrote:
> > > * devel/libSavitar
> > > * net/libArcus
> > > * net/libCharon
> >
> > all lowercase for these port names please
> >
>
> other comments: (paco's are generally good too)
>
> - all the ultimaker distfiles have the same version 4.6.2 which implies
> that they probably want updating together, it might be easier to do that
> if they're grouped e.g. cad/ultimaker/{cura,cura-engine,fdm_materials,...}
>
> - SHARED_LIBS should all start with 0.0 for new ports. if the ports don't
> honour that setting in the files they produce, that needs correcting.
>
> - libCharon should use MODULES=lang/python and the python-related variables
> in PLIST etc. the python module messes about with CONFIGURE_STYLE, you can
> avoid that with CONFIGURE_STYLE=none
>
> > * devel/py-trimesh
> > * No need for that NEEDED_DEPENDS. Define BUILD_DEPENDS and
> later
> > RUN_DEPENDS = ${BUILD_DEPENDS}
>
> ah, this is wrong, BUILD_DEPENDS can have other things added to it (ccache,
> build tools, etc), RUN_DEPENDS should not be set based on it.
>
> one of them has cython as a run dep; haven't looked closer but this is
> normally something that would be a build dep
>
> there are various ones with constructs like
>
> V= 1.23
> GH_TAGNAME= ${V}
> DISTNAME= bar-${V}
>
> and some others with an additional variable; much of this is not needed,
> if you do this
>
> GH_ACCOUNT= foo
> GH_PROJECT= bar
> GH_TAGNAME= v1.23
>
> the following vars are set automatically and it's better not to explicitly
> set them:
>
> DISTNAME= bar-1.23 (auto strips the 'v')
> HOMEPAGE= https://github.com/foo/bar
>
> and where you have mixed-case ones that need lower-casing you can do e.g.
>
> GH_PROJECT= libBar
> PKGNAME= ${DISTNAME:L}
>
> some of the ultimaker port PKGNAMEs end up mixed-case as well, those should
> be lowered too
>
