On 1/8/2013 5:26 PM, Patrick Ben Koetter wrote:
> * Wietse Venema <postfix-users@postfix.org>:
>> Patrick Ben Koetter:
>>>> Next, a few examples that are likely to be implemented:
>>>>
>>>> postconf -M# service-type ...
>>>> postconf -M# service-type.service-name ...
>>>>
>>>> postconf -MX service-type ...
>>>> postconf -MX service-type.service-name ...
>>>>
>>>> Delete (or comment) out the specified services.
>>>
>>> Would it make sense - differing from main.cf behaviour - to revert
>>> comments in master.cf?
>>
>> In both cases, I don't understand how that would work.
>
> Neither do I.
>
> Here's the problem I'd like to solve: The submission service is commented out
> by default. Nowadays I enable it very often when I install Postfix. Issuing a
> command that removes/reverts the comments from e.g. the submission service
> sounds just like a feature that would solve my problem. Thus the investigation
> if it made sense to revert comments in master.cf.
I don't think "uncomment" is particularly useful. Just ignore
commented entries; add a new entry with the desired settings. That
way you don't have to worry about multiple matching comments with
the same name.
>
> On a sidenote: At the moment "postconf -M ..." doesn't seem to list service
> types that are commented out. Unless I haven't missed a way it would probably
> make sense to list them if comments were to be reverted.
I think comments should be ignored by the automated tools.
And yes, the docs should strongly encourage the user to back up *.cf
before mucking around with them. I can imagine postconf saving the
unmodified file to eg. ./rescue/master.cf-{date+time}.
-- Noel Jones
