On Saturday 27 June 2009 00:13:13 Kok, Auke wrote: > Matthew Garrett wrote: > > On Fri, Jun 26, 2009 at 03:00:47PM -0700, Kok, Auke wrote: > >> Matthew Garrett wrote: > >>> I'd actually suggest that powertop stop making this suggestion. The > >>> kernel and userspace will be updated as hardware is verified, but > >>> there's no real way powertop itself can decide whether it's safe to > >>> enable USB autosuspend or not. > >> > >> are you saying that we need to just remove the parts which write to > >> power/autosuspend only? > > > > Writing to power/autosuspend only makes sense if it's currently set to > > -1. > > > >> or do we currently (new kernels etc) want to stop setting power/level to > >> "auto" as well? This still leaves the kernel in charge. > > > > Right, but the problem here is that the kernel will then suspend idle > > input devices - and the common case is that you don't want that to > > happen. powertop would need to carry its own white or blacklist of > > drivers and devices if it's going to enable that. We default autosuspend > > off on most devices because it can be dangerous. > > I'm all for actually giving people actually a chance to 'break' their > system. having a keyboard break because someone used powertop isn't that > bad: We find out that there is a bad keyboard out there first of all, > something we would have missed completely. > > It seems powertop is currently the only piece of software around that we > can use for this purpose, might as well use it then :) > > when does the kernel set 'power/autosuspend' to -1?
I agree that it might be better to just set power/level to auto if power/autosuspend is already > 0. In my case at least this would work quite well (except that I have to click to wake up the mouse, which becomes uncomfortable), while if you set power/autosuspend to 0 the mouse remains dead. My default for power/autosuspend is 2. > > we can certainly 'blacklist' "input" devices, if there was an elegant way > to detect whether a device is indeed such a thing from sysfs... > > Auke _______________________________________________ Power mailing list [email protected] http://www.bughost.org/mailman/listinfo/power
