I do not know if patch pinging is as acceptable on this list, If not then please tell me.
Anyway, here goes. I think that at least the readlink patch is important. /MF On Wed, 2010-05-26 at 09:23 +0200, Magnus Fromreide wrote: > Hello. > > I went over powertop trying to reduce the number of compilation warnings > it produced and found a few things I think are worthwile to add, I list > them according to how important I percieve each one to be. > > readlink.diff: > First, the size limit is set to sizeof(link), in this context > link refers to link(2) so this looks plain wrong. > Secondly len is unused so let's just remove it. Use (void)fun() > to silence lint if necessary. > > remove-unused-ifaceup.diff: > In find_wireless_nic(void) there is some work done to set the > variable ifaceup but then it is never used. The patch removes > the setting of the variable but if the intention was to use it > then an alternative patch is needed. > > kill-spurious-semicolon.diff: > powertop.c starts with a semicolon. Make it stop doing that. > > lower-declaration.diff: > Reduce the scope of a variable to the smallest possible one. > _______________________________________________ > Power mailing list > [email protected] > http://www.bughost.org/mailman/listinfo/power _______________________________________________ Power mailing list [email protected] http://www.bughost.org/mailman/listinfo/power
