On 07/19/10 12:12, Andreas Mohr wrote: > Hi, > > On Thu, Jul 15, 2010 at 03:23:11PM -0700, Auke Kok wrote: >> yup, that's unexpected. >> >> indeed this needs fixing, but probably best using sysfs nodes to do >> these lookups anyway. I'll mark this TODO, and see if I can find an easy >> fix. > > Just saw that it's working now. > Why did one choose to implement this with an ugly duplicate hardcoded check? > Using /usr/bin/env as described would have been much better IMHO, > especially since AFAIK env is a REQUIRED (and fixed-positioned!) > part of any system. > (ok, well, probably it's somewhat slower since one has to launch env _and_ > lspci > for each request...)
eh, this is new code and Arjan is spending a ton of time making stuff work quickly now. I'm gonna do a duplication cleanup pass on this code soon and will probably rewrite this to use sysfs/procfs just like the rest of the code, and then this will be fixed once and for all. Using env is just as bad of a hack ;) Auke _______________________________________________ Power mailing list [email protected] http://www.bughost.org/mailman/listinfo/power
