On 12/02/10 03:08, Jaroslav Skarvada wrote: >> I took your patch and fixed it up quite a bit to accomodate for some >> other changes that went into git. Can you pull the latest git, apply >> below modified patch and give this a test and see if it does what you >> want it to? >> > > Thanks. I had to slightly modify your patch to apply, because there > were mismatches in whitespaces, line breaks and one line was listed > twice (probably by mistake). > > But it seems not to work correctly. The last line of C and P states is > not shown in interactive mode on my test machine. On the other machine > the C/P state window is not correctly placed. I think there are > several problems. The window size for C states is probably not > correctly computed, because the maxcstate can be 4 or 6, but there > need not be C3 or C5 thus the maxcstate need not correspond to the > number of lines - I added code that tries to find out number of lines. > I also removed maxfreq as maxpstate seems to be alias. > I tried to simplify/correct show_c_and_p_states as it missed one state > on my testing machine. The problem - now there is no trim for high > number of C states in interactive mode, but I think that the previous > code was not correct as well. I also added newlines to > "no C/P states info", because there were not correctly wrapped in dump > mode. Now it works OK on my testing machines, but maybe there are still > some hidden problems
OK, yeah, this looks better, thanks for taking the time to redo the patch. It works ok as far as I can see here, so I've tossed it in to git. Thanks, Auke _______________________________________________ Power mailing list [email protected] http://www.bughost.org/mailman/listinfo/power
