Hi, On Thu, Dec 23, 2010 at 07:07:39PM -0800, Arjan van de Ven wrote: > I'd like to ask everyone who's interested to give it a spin and give > feedback on how you like the new design,
I don't like it since I cannot even see it ;) cc -Wall -O2 -g -fno-omit-frame-pointer -fstack-protector -Wshadow -Wformat -DCONFIG_LIBNL20 -Wall -O2 -g -fno-omit-frame-pointer -c -o tuning/iw.o tuning/iw.c tuning/iw.c: In function âset_power_saveâ: tuning/iw.c:131: error: storage size of âps_stateâ isnât known tuning/iw.c:133: error: âNL80211_PS_DISABLEDâ undeclared (first use in this function) tuning/iw.c:133: error: (Each undeclared identifier is reported only once tuning/iw.c:133: error: for each function it appears in.) tuning/iw.c:135: error: âNL80211_PS_ENABLEDâ undeclared (first use in this function) tuning/iw.c:137: error: âNL80211_ATTR_PS_STATEâ undeclared (first use in this function) tuning/iw.c:131: warning: unused variable âps_stateâ tuning/iw.c: In function âprint_power_save_handlerâ: tuning/iw.c:153: error: âNL80211_ATTR_PS_STATEâ undeclared (first use in this function) tuning/iw.c:157: error: âNL80211_PS_ENABLEDâ undeclared (first use in this function) tuning/iw.c:160: error: âNL80211_PS_DISABLEDâ undeclared (first use in this function) tuning/iw.c: In function â__handle_cmdâ: tuning/iw.c:228: error: âNL80211_CMD_GET_POWER_SAVEâ undeclared (first use in this function) tuning/iw.c:231: error: âNL80211_CMD_SET_POWER_SAVEâ undeclared (first use in this function) make: *** [tuning/iw.o] Error 1 # dpkg -S /usr/include/linux/nl80211.h linux-libc-dev: /usr/include/linux/nl80211.h # dpkg -s linux-libc-dev Package: linux-libc-dev Status: install ok installed Priority: optional Section: devel Installed-Size: 4072 Maintainer: Debian Kernel Team <[email protected]> Architecture: i386 Source: linux-2.6 Version: 2.6.32-29~bpo50+1 Replaces: linux-kernel-headers Provides: linux-kernel-headers Conflicts: linux-kernel-headers Description: Linux support headers for userspace development This package provides userspaces headers from the Linux kernel. These headers are used by the installed headers for GNU glibc and other system libraries. That probably needs an NL80211 version check for these definitions. OK, I did want to see the new design, thus I killed iw.o, which resulted in: g++ lib.o main.o display.o html.o cpu/cpu.o cpu/abstract_cpu.o cpu/cpu_linux.o cpu/cpu_core.o cpu/cpu_package.o cpu/intel_cpus.o cpu/cpudevice.cpp perf/perf.o perf/perf_bundle.o process/process.o process/do_process.o process/interrupt.o process/timer.o process/work.o process/powerconsumer.o process/device.o devices/device.o devices/backlight.o devices/usb.o devices/ahci.o devices/alsa.o devices/rfkill.o devices/i915-gpu.o devices/thinkpad-fan.o devices/network.o devices/runtime_pm.o measurement/measurement.o measurement/acpi.o parameters/parameters.o parameters/learn.o parameters/persistent.o calibrate/calibrate.o tuning/tuning.o tuning/tunable.o tuning/sysfs.o tuning/usb.o tuning/runtime.o tuning/bluetooth.o tuning/cpufreq.o tuning/ethernet.o tuning/wifi.o -lnl-genl -lnl -lnl-route -lnl-nf -lnl-genl -lnl-cli -lpthread -lncursesw -lpci -lz -lresolv -o powertop devices/network.o: In function `network::end_measurement()': /usr/src/system/GIT/powertop-2.0/devices/network.cpp:306: undefined reference to `get_wifi_power_saving' calibrate/calibrate.o: In function `calibrate()': /usr/src/system/GIT/powertop-2.0/calibrate/calibrate.cpp:453: undefined reference to `get_wifi_power_saving' /usr/src/system/GIT/powertop-2.0/calibrate/calibrate.cpp:461: undefined reference to `set_wifi_power_saving' /usr/src/system/GIT/powertop-2.0/calibrate/calibrate.cpp:476: undefined reference to `set_wifi_power_saving' calibrate/calibrate.o: In function `restore_all_sysfs': /usr/src/system/GIT/powertop-2.0/calibrate/calibrate.cpp:85: undefined reference to `set_wifi_power_saving' tuning/wifi.o: In function `wifi_tunable::toggle()': /usr/src/system/GIT/powertop-2.0/tuning/wifi.cpp:69: undefined reference to `set_wifi_power_saving' /usr/src/system/GIT/powertop-2.0/tuning/wifi.cpp:65: undefined reference to `set_wifi_power_saving' tuning/wifi.o: In function `wifi_tunable::good_bad()': /usr/src/system/GIT/powertop-2.0/tuning/wifi.cpp:53: undefined reference to `get_wifi_power_saving' collect2: ld returned 1 exit status make: *** [powertop] Error 1 Since these are helpers provided by iw.o, I'd have to _cleanly_ disable this functionality to get a properly working powertop 2.0 (more likely by hacking iw.o to provide sane dummy results than by blindly disabling iw calls in network.c etc.), which I currently don't feel like doing. Thanks for your continued work on this nice tool! Andreas Mohr _______________________________________________ Power mailing list [email protected] http://www.bughost.org/mailman/listinfo/power
