On Wednesday 10 August 2005 11:56, Thomas Renninger wrote: > Stefan Seyfried wrote: > > Thomas Renninger wrote: > >>>I don't think so. Maybe I think my mashine is on power and suddenly the > >>>light goes out. > >> > >>If you assume online the light should go on, or? > > > > not necessarily. Due to a hal bug (fixed) my machine always told me AC > > was on although i had forgotten to plug it in. Since i was "online", i > > did not get any warning about battery state and suddenly the light went > > off. > > > > This is an important part which i never thought about before: > > > > If battery is (low|warning|critical) and we are (offline|unknown), > > notify the user. Right now, we only notify if we are offline, but not if > > online or unknown (which is "assume online"). > > Good point. > But be careful, you possibly have to touch other code parts where > I expected ac to only be ONLINE/OFFLINE in daemon/* code. > Maybe also in kpowersave...
for kpowersave: no, I reported this problem and I would know if the state of AC is unknown e.g. if maybe HAL is down. In this case kpowersave can try to get the AC state from /proc/acpi. It's IMHO always better to set such things to unknown if unknown and not to dupe a (wrong) state Danny _______________________________________________ powersave-devel mailing list [email protected] http://forge.novell.com/mailman/listinfo/powersave-devel
