Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/184#discussion_r163092194
  
    --- Diff: src/java/org/apache/cassandra/net/MessagingService.java ---
    @@ -766,15 +766,16 @@ private void listen(InetAddress localEp, 
ServerEncryptionOptions serverEncryptio
                 ServerEncryptionOptions legacyEncOptions = new 
ServerEncryptionOptions(serverEncryptionOptions);
                 legacyEncOptions.optional = false;
     
    -            InetSocketAddress localAddr = new InetSocketAddress(localEp, 
DatabaseDescriptor.getSSLStoragePort());
    +            InetAddressAndPort localAddr = 
InetAddressAndPort.getByAddressOverrideDefaults(localEp.address, 
DatabaseDescriptor.getSSLStoragePort());
                 ChannelGroup channelGroup = new 
DefaultChannelGroup("LegacyEncryptedInternodeMessagingGroup", 
NettyFactory.executorForChannelGroups());
                 InboundInitializer initializer = new 
InboundInitializer(authenticator, legacyEncOptions, channelGroup);
                 Channel encryptedChannel = 
NettyFactory.instance.createInboundChannel(localAddr, initializer, 
receiveBufferSize);
                 serverChannels.add(new ServerChannel(encryptedChannel, 
channelGroup, localAddr, ServerChannel.SecurityLevel.REQUIRED));
             }
     
             // this is for the socket that can be plain, only ssl, or optional 
plain/ssl
    -        InetSocketAddress localAddr = new InetSocketAddress(localEp, 
DatabaseDescriptor.getStoragePort());
    +        assert localEp.port == DatabaseDescriptor.getStoragePort() : 
String.format("Local endpoint port %d doesn't match YAML configured port %d%n", 
localEp.port, DatabaseDescriptor.getStoragePort());
    --- End diff --
    
    I probably encountered an incorrectly sourced port value at some point. If 
we send it out with the wrong port we'll never get the response :-)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to