Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/184#discussion_r163093996
  
    --- Diff: src/java/org/apache/cassandra/tools/LoaderOptions.java ---
    @@ -122,8 +129,11 @@
             EncryptionOptions clientEncOptions = new EncryptionOptions();
             int connectionsPerHost = 1;
             EncryptionOptions.ServerEncryptionOptions serverEncOptions = new 
EncryptionOptions.ServerEncryptionOptions();
    -        Set<InetAddress> hosts = new HashSet<>();
    -        Set<InetAddress> ignores = new HashSet<>();
    +        Set<InetAddress> hostsArg = new HashSet<>();
    +        Set<InetAddress> ignoresArg = new HashSet<>();
    +        Set<InetSocketAddress> hosts = new HashSet<>();
    --- End diff --
    
    The loader is a client not really part of the database and interacts with 
the Java driver using InetSocketAddress.
    
    The rule is that an InetSocketAddress should never refer to the storage 
port. InetAddressAndPort might refer to the client port though in some of the 
internal code in the server though.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to