Github user aweisberg commented on a diff in the pull request:

    https://github.com/apache/cassandra/pull/278#discussion_r223398346
  
    --- Diff: src/java/org/apache/cassandra/net/MessagingService.java ---
    @@ -1078,7 +1078,7 @@ public void sendOneWay(MessageOut message, int id, 
InetAddressAndPort to)
                 logger.trace("{} sending {} to {}@{}", 
FBUtilities.getBroadcastAddressAndPort(), message.verb, id, to);
     
             if (to.equals(FBUtilities.getBroadcastAddressAndPort()))
    -            logger.trace("Message-to-self {} going over MessagingService", 
message);
    +            logger.warn("Message-to-self {} going over MessagingService", 
message);
    --- End diff --
    
    My last thought is that as a user I can't do much with this information. 
It's mostly harmless, but I also can't fix it other than by filing a bug 
report. 
    
    I think this is the biggest issue with this change. It will cause people 
worry when nothing is wrong. I think this should be debug not warn because no 
action is required on part of a user (as opposed to a developer).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to