Github user aweisberg commented on a diff in the pull request:
https://github.com/apache/cassandra/pull/278#discussion_r223876124
--- Diff: src/java/org/apache/cassandra/net/MessagingService.java ---
@@ -1078,7 +1078,7 @@ public void sendOneWay(MessageOut message, int id,
InetAddressAndPort to)
logger.trace("{} sending {} to {}@{}",
FBUtilities.getBroadcastAddressAndPort(), message.verb, id, to);
if (to.equals(FBUtilities.getBroadcastAddressAndPort()))
- logger.trace("Message-to-self {} going over MessagingService",
message);
+ logger.debug("Message-to-self {} going over MessagingService",
message);
--- End diff --
This really needs to be NoSpamLogger? How many times a second might we do
this in some cases? What if new code comes that causes this to occur many times
a second?
In OSS debug logging is on all the time. That's really not a risk we should
be taking.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
