dcapwell commented on a change in pull request #470: CASSANDRA-15630 fix
testSerializeError
URL: https://github.com/apache/cassandra/pull/470#discussion_r393923257
##########
File path: test/unit/org/apache/cassandra/net/ConnectionUtils.java
##########
@@ -240,6 +247,27 @@ private void doCheck(FailCheck testAndFailCheck)
}
}
+ private static void longCheck(Runnable assertion, long timeout, TimeUnit
timeUnit)
+ {
+ long start = System.currentTimeMillis();
Review comment:
`System.currentTimeMillis` is free to go backwards (its not monotonic, this
is system time) so its normally best to use `.nanoTime()` (CPU time).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
