dcapwell commented on a change in pull request #470: CASSANDRA-15630 fix
testSerializeError
URL: https://github.com/apache/cassandra/pull/470#discussion_r393925866
##########
File path: test/unit/org/apache/cassandra/net/ConnectionTest.java
##########
@@ -487,13 +487,13 @@ public long serializedSize(Object o, int version)
.overload ( 0, 0)
.expired ( 0, 0)
.error ( 10, 10 *
message.serializedSize(version))
- .check();
+ .longCheck( 5, SECONDS);
Review comment:
would also be good to document why not check; you say it in the JIRA but a
code comment is easier to future readers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
