blerer commented on a change in pull request #482: CASSANDRA-15650 Fix flaky
test org.apache.cassandra.distributed.test.*RepairCoordinatorFastTest
URL: https://github.com/apache/cassandra/pull/482#discussion_r399163058
##########
File path: src/java/org/apache/cassandra/tools/NodeProbe.java
##########
@@ -1807,6 +1805,11 @@ public MessagingServiceMBean getMessagingServiceProxy()
{
return msProxy;
}
+
+ public long getJmxNotificationPollIntervalSeconds()
+ {
+ return
Long.getLong("cassandra.nodetool.jmx_notification_poll_interval_seconds",
TimeUnit.SECONDS.convert(5, TimeUnit.MINUTES));
+ }
Review comment:
It is not clear to me what is the advantage of using a method over a
constant.
Usually all system variables within C* are read and stored within constants.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
