blerer commented on a change in pull request #482: CASSANDRA-15650 Fix flaky
test org.apache.cassandra.distributed.test.*RepairCoordinatorFastTest
URL: https://github.com/apache/cassandra/pull/482#discussion_r400045766
##########
File path: src/java/org/apache/cassandra/repair/RepairRunnable.java
##########
@@ -227,8 +227,14 @@ private void complete(String msg)
public void run()
{
+ String previousName = Thread.currentThread().getName();
try
{
+ Thread.currentThread().setName(NamedThreadFactory.globalPrefix()
+ + "Repair Coordinator #" + cmd
+ + " id=" + parentSession
+ + " ks=" + keyspace
+ + " tables=" +
options.getColumnFamilies());
Review comment:
Thread dumps are only one of the tools that use thread names. Logs,
JConsole, Profilers also use them. If the name of a thread keep on changing, it
is pretty hard to understand what is truly going on and you cannot monitor what
happen to a given thread over time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
