bereng commented on a change in pull request #870:
URL: https://github.com/apache/cassandra/pull/870#discussion_r570744774
##########
File path:
test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java
##########
@@ -269,6 +276,63 @@ public void testCreateAlterKeyspaces() throws Throwable
"max_threshold", "32")));
}
+ @Test
+ public void testCreateAlterKeyspacesRFWarnings() throws Throwable
+ {
+ requireNetwork();
+ Thread.sleep(1000); // Hack: requireNetwork() will clear warnings
async so give some time to complete
Review comment:
If you run:
- Test class + no `requireNetwrok()`: pass
- Test class + `requireNetwrok()`: fail unless you sleep
- Test method + no `requireNetwrok()`: fail bc test sees 0 nodes and we
short circuit that
- Test method + `requireNetwrok()`: pass
The problem being warnings goes to null as they get 'cleared'.
##########
File path:
test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java
##########
@@ -269,6 +276,63 @@ public void testCreateAlterKeyspaces() throws Throwable
"max_threshold", "32")));
}
+ @Test
+ public void testCreateAlterKeyspacesRFWarnings() throws Throwable
+ {
+ requireNetwork();
+ Thread.sleep(1000); // Hack: requireNetwork() will clear warnings
async so give some time to complete
Review comment:
If you run:
- Test class + no `requireNetwrok()`: pass
- Test class + `requireNetwrok()`: fail unless you sleep
- Test method + no `requireNetwrok()`: fail bc test sees 0 nodes and we
short circuit that
- Test method + `requireNetwrok()`: pass
The problem being warnings goes to null as they get 'cleared' unless you
sleep.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
