bereng commented on a change in pull request #870:
URL: https://github.com/apache/cassandra/pull/870#discussion_r571890058
##########
File path: src/java/org/apache/cassandra/dht/RangeStreamer.java
##########
@@ -353,9 +361,27 @@ public void addRanges(String keyspaceName,
ReplicaCollection<?> replicas)
*/
private boolean useStrictSourcesForRanges(AbstractReplicationStrategy
strat)
{
- return useStrictConsistency
- && tokens != null
- && metadata.getSizeOfAllEndpoints() !=
strat.getReplicationFactor().allReplicas;
+ boolean res = useStrictConsistency && tokens != null;
+
+ if (res)
+ {
+ int nodes = 0;
+
+ if (strat instanceof NetworkTopologyStrategy)
Review comment:
I am not following your explanation sorry.
In any case notice we're comparing the number of _replicating nodes_ (not
nodes, but replicating nodes only) to the RF. So if you have 6 nodes but only 3
are _replicas_ you should behave as if there were only 3 nodes towards the RF,
not 6 bc one dc is _not_ replicating i.e. Does it help?
Yep method doc also points towards `>` which makes sense to me. Idk why it
was `!=`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
